Remove unneeded camera follow offset checks #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <[email protected]>
iche033
commented
Jun 10, 2021
| @@ -1644,10 +1644,6 @@ void IgnRenderer::HandleMouseViewControl() | |||
| << std::endl; | |||
| } | |||
|
|
|||
| math::Vector3d camWorldPos; | |||
| if (!this->dataPtr->followTarget.empty()) | |||
| this->dataPtr->camera->WorldPosition(); | |||
There was a problem hiding this comment.
the bug is likely here. This should probably have been:
math::Vector3d camWorldPos;
if (!this->dataPtr->followTarget.empty())
camWorldPos = this->dataPtr->camera->WorldPosition();
8 tasks
Codecov Report
@@ Coverage Diff @@
## ign-gazebo4 #857 +/- ##
===============================================
+ Coverage 65.70% 65.72% +0.01%
===============================================
Files 240 240
Lines 17788 17783 -5
===============================================
Hits 11687 11687
+ Misses 6101 6096 -5
Continue to review full report at Codecov.
|
8 tasks
jennuine
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen [email protected]
🦟 Bug fix
Summary
When handling mouse movements in camera follow mode, , there is a check to see if camera has actually moved or not. If it has moved, the camera offset is marked as dirty. However, I found that this check always passes because a variable (
camWorldPos) is never set. It also looks like the check is just unnecessary and we are just doing additional calculations so I just removed the check.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge